Misc fixes and improvements #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since there's no signal handlers involved and signals are handled with regular code via signalfd.
otherwise running something like `clipmenud --verbose` gives the false impression of it "working".
negative values don't make sense for these config vars, so reject them. also reject values that are too large and would get truncated.
|
These look fine, thanks. My general feeling is that if one willingly shoots themself in the foot that's fine, but I am also fine with not providing the bullets :) And thanks for noticing we no longer need sig_atomic_t, that's from before the signalfd migration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clipmenud: no need to use volatile sig_atomic_t
since there's no signal handlers involved and signals are
handled with regular code via signalfd.
clipmenud: don't silently ignore arguments
otherwise running something like
clipmenud --verbosegives thefalse impression of it "working".
config: range check parsed integers
negative values don't make sense for these config vars, so
reject them.
also reject values that are too large and would get truncated.
clipmenud: correct cast to size_t